bitlair/revbank
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
revbank/plugins
History
Juerd Waalboer 09411bb6c0 give: Don't do checkout with description as username 
Originally, this command didn't have a description parameter. Foo would
use `give xyzzy 10 foo`. Then, a description parameter was added. For
backwards compatibility, if you would enter a username (like `foo` in
this example) in the place of the description, it would finalize the
transaction using that.

However, as the user base grows, several reasonable descriptions exist as
user account names, and that would finalize the transaction under the
wrong user.

It's time to break backward compatibility. If you don't want to leave a
message (it's still optional), that can be done with `x` (like the
`donate` command), or in advanced mode, with `""`.

Because it's likely that people are still very much used to just leaving
the description out, if you enter something that happens to match an
existing username, the input will be rejected.

The current equivalent command line would be `give xyzzy 10 ""; foo` or
`give xyzzy 10 x; foo`. If the `;` (new since v5.0.0) is left out, the
trailing `foo` has to be confirmed with a second press of the enter key.
2023-12-26 05:47:29 +01:00
..
adduser adduser: use tab completion lists to catch some more clashes 2023-11-02 03:57:46 +01:00
adduser_note New plugin: adduser_note 2023-09-20 20:12:42 +02:00
beep Cleanup: use subroutine signatures, remove deprecated methods. 2021-12-03 18:00:34 +01:00
beep_terminal Cleanup: use subroutine signatures, remove deprecated methods. 2021-12-03 18:00:34 +01:00
cash New feature: cash box check via 'cash' command 2022-08-27 06:04:56 +02:00
cash_drawer New plugin: cash_drawer (example code; incomplete) 2023-02-14 00:31:41 +01:00
deduplicate Fix deduplication bug, refactor deduplication to own plugin 2023-02-12 17:53:14 +01:00
deposit Allow statiegeld return via deposit command 2023-01-16 04:38:10 +01:00
deposit_iban_qr Cleanup: use subroutine signatures, remove deprecated methods. 2021-12-03 18:00:34 +01:00
deposit_methods Cleanup: use subroutine signatures, remove deprecated methods. 2021-12-03 18:00:34 +01:00
deprecated_raw Move deprecation warning to separate plugin 2023-02-12 22:01:31 +01:00
dinnerbonus Cleanup: use subroutine signatures, remove deprecated methods. 2021-12-03 18:00:34 +01:00
edit v3.6: products overhaul 2022-12-25 05:32:00 +01:00
give give: Don't do checkout with description as username 2023-12-26 05:47:29 +01:00
grandtotal Add support for user-accessible accounts that are excluded from grandtotal 2023-11-02 05:33:33 +01:00
help Split "help" into "help" and "help2"; ditch pager 2022-06-11 16:31:44 +02:00
idle idle: use underline instead of dim/faint 2023-06-10 22:24:14 +02:00
json Document another caveat 2022-01-19 17:58:18 +01:00
log statiegeld_tokens: log creation, use, and expiry of tokens 2023-02-02 01:24:30 +01:00
market Fix deduplication bug, refactor deduplication to own plugin 2023-02-12 17:53:14 +01:00
products products: clear products cache before reading products list 2023-09-18 00:04:00 +02:00
products.pod Typo in documentation 2023-01-29 19:28:08 +01:00
regex_angel Upstream support for angel-foo input as alias for foo. 2023-09-18 01:35:11 +02:00
regex_gtin gtin: fix spamurl, support element string without parentheses 2023-09-20 00:06:12 +02:00
repeat Highlight change; apply operators to last scanned instead of last added 2023-01-30 04:40:42 +01:00
restart restart: only suppress warnings of the 'exec' category 2023-11-02 03:12:26 +01:00
revspace_ascii New plugin: revspace_ascii 2019-11-07 04:07:31 +01:00
revspace_barcode Fix deduplication bug, refactor deduplication to own plugin 2023-02-12 17:53:14 +01:00
revspace_git Cleanup: use subroutine signatures, remove deprecated methods. 2021-12-03 18:00:34 +01:00
revspace_mollie Bump to v3.4; make all transactions balanced using hidden accounts 2022-06-11 18:51:26 +02:00
revspace_mqtt Implement global advisory lock 2022-08-29 17:50:12 +02:00
revspace_saldo Update limit 19.84 -> 22.00 2023-04-11 23:53:55 +02:00
revspace_terminal Remove requirement for dummy command method in hook-only plugins 2021-12-03 01:49:11 +01:00
revspace_window Add revspace specific plugins 2019-09-23 21:12:03 +02:00
sighup Add plugin 'sighup' 2023-11-02 03:12:17 +01:00
sigint Remove requirement for dummy command method in hook-only plugins 2021-12-03 01:49:11 +01:00
skim Add cash box tracking with new plugin "cash" 2022-06-11 21:16:47 +02:00
split split: remove irrelevant tab completions 2023-11-02 03:52:32 +01:00
statiegeld statiegeld: fix typo in ansi escape 2023-06-10 22:26:21 +02:00
statiegeld.pod Move and extend statiegeld documentation 2023-01-20 18:42:04 +01:00
statiegeld_tokens undo: assert undoability instead of rolling back invalid undo 2023-12-26 02:10:34 +01:00
statiegeld_tokens.pod Document statiegeld_tokens 2023-01-24 21:45:05 +01:00
stock Implement global advisory lock 2022-08-29 17:50:12 +02:00
tail tail/users: fix warning when used with old log files 2023-11-02 04:45:03 +01:00
take take: Improve error message 2023-12-26 05:47:29 +01:00
undeposit New plugin: undeposit 2022-06-18 21:55:40 +02:00
undo undo: assert undoability instead of rolling back invalid undo 2023-12-26 02:10:34 +01:00
unlisted Add message to donate command 2023-04-12 16:19:04 +02:00
url url: Print line but don't skip "no such product/..." error message 2023-09-18 01:33:35 +02:00
users Ignore all hook exceptions except in hook_checkout_prepare 2023-11-24 05:15:22 +01:00
vat vat: remove unused variable 2023-09-18 15:30:00 +02:00
vat.pod Document vat plugin 2023-09-18 15:08:55 +02:00
warnings Implement global advisory lock 2022-08-29 17:50:12 +02:00
window_title Add window_title plugin 2023-02-02 01:42:41 +01:00
withdraw Move deprecation warning to separate plugin 2023-02-12 22:01:31 +01:00