Split "help" into "help" and "help2"; ditch pager

lib/RevBank/Plugins.pm

@@ -65,6 +65,9 @@ sub load($class) {
             sub FETCH_CODE_ATTRIBUTES {
                 return \$ATTR{ +pop };
             }
+            sub HELP1 {
+                \$::HELP1{ +shift } = +pop;
+            }
             sub HELP {
                 \$::HELP{ +shift } = +pop;
             }

plugins/adduser

@@ -1,6 +1,6 @@
 #!perl
 
-HELP "adduser <name>" => "Create an account";
+HELP1 "adduser <name>" => "Create an account";
 
 sub command :Tab(adduser) ($self, $cart, $command, @) {
     $command eq 'adduser' or return NEXT;

plugins/deposit

@@ -2,7 +2,7 @@
 
 # This plugin must at the end in the plugins file.
 
-HELP "deposit <amount>" => "Deposit into an account";
+HELP1 "deposit <amount>" => "Deposit into an account";
 
 sub command :Tab(deposit) ($self, $cart, $command, @) {
     $command eq 'deposit' or return NEXT;

plugins/help

@@ -1,6 +1,6 @@
 #!perl
 
-HELP "help" => "The stuff you're looking at right now :)";
+HELP1 "help2" => "Advanced usage instructions";
 
 use List::Util qw(max);
 
@@ -8,28 +8,17 @@ my $bold = "\e[1m";
 my $underline = "\e[4m";
 my $off = "\e[0m";
 
-sub command :Tab(help,wtf,omgwtfbbq) ($self, $cart, $command, @) {
-    return NEXT if $command !~ /^(?:help|wtf|omgwtfbbq)$/;
+sub command :Tab(help,help2,wtf,omgwtfbbq) ($self, $cart, $command, @) {
+    return NEXT if $command !~ /^(?:help2?|wtf|omgwtfbbq)$/;
 
-    # GNU less(1) and more(1) are a bad choice to present to total newbies who
-    # might have no interest in learning to use these surprisingly powerful
-    # tools, so I will not accepting patches to use either of those, or to use
-    # the PAGER environment variable (because that will typically be set to
-    # either one of those by default). For example, typing "v" will excute
-    # vi...
-    # On the other hand, busybox(1) has a "more" applet that gives the user
-    # clear instructions and seems mostly harmless too.
-    my $pipe;
-    my $oldhandle = select;
-    if (open $pipe, "|-", "busybox", "more") {
-        select $pipe;
-    }
+    my $help2 = $command =~ /help2/;
+    my $hash = $help2 ? \%::HELP : \%::HELP1;
 
     say "\n${bold}Valid commands:${off}";
 
-    my $width = max(map length s/[<>]//rg, keys %::HELP);
+    my $width = max(map length s/[<>]//rg, keys %$hash);
 
-    for my $command (sort keys %::HELP) {
+    for my $command (sort keys %$hash) {
         my $display = $command;
 
         my $length = length $display =~ s/[<>]//rg;
@@ -40,18 +29,19 @@ sub command :Tab(help,wtf,omgwtfbbq) ($self, $cart, $command, @) {
         # Because of markup codes, a simple %-42s doesn't work.
         $display .= " " x ($width - $length);
 
-        say sprintf "  %s %s", $display, $::HELP{$command};
+        say sprintf "  %s  %s", $display, $hash->{$command};
     }
 
+    my $advanced = $help2
+        ? "${bold}Advanced usage:${off} pass space separated arguments to parameters"
+        : "";  # Line intentionally left blank
+
     print <<"END";
 
 ${bold}Simple usage:  ${off} press <Enter> after a command for follow-up prompts
-${bold}Advanced usage:${off} pass space separated arguments to parameters
+$advanced
 Complete each transaction with ${underline}account${off} (i.e. enter your name).
 END
 
-    select $oldhandle;
-    close $pipe;
-
     return ACCEPT;
 }

plugins/products

@@ -1,7 +1,7 @@
 #!perl
 
-HELP "<productID>" => "Look up products from database";
-HELP "edit" => "Edit product list";
+HELP1 "<productID>" => "Add a product to pending transaction";
+HELP  "edit" => "Edit product list";
 
 my $filename = 'revbank.products';
 

plugins/repeat

@@ -1,6 +1,7 @@
 #!perl
 
-HELP "*<N>, x<N>, <N>x, <N>*" => "Repeat previous/next product N times";
+HELP "*<N>, x<N>, <N>x, <N>*" => "Set quantity of previous/next product";
+HELP "-<N>, +<N>" => "Decrease/increase quantity of previous product";
 
 my $err_stacked = "Stacked repetition is not supported.";
 my $err_pfand = "Plugins 'pfand' and 'repeat' cannot be combined.";

plugins/stock

@@ -1,6 +1,6 @@
 #!perl
 
-HELP "cash" => "Checkout without a user account";
+HELP1 "cash" => "Checkout without a user account";
 
 sub command :Tab(cash) ($self, $cart, $command, @) {
     return NEXT if $command ne 'cash';

plugins/undo

@@ -1,6 +1,6 @@
 #!perl
 
-HELP "undo <transactionID>" => "Undo a transaction";
+HELP1 "undo <transactionID>" => "Undo a transaction";
 
 my $filename = ".revbank.undo";
 

plugins/unlisted

@@ -1,6 +1,6 @@
 #!perl
 
-HELP "unlisted" => "Buy unlisted product (manual entry)";
+HELP1 "unlisted" => "Buy unlisted product (manual entry)";
 
 sub command :Tab(unlisted,donate) ($self, $cart, $command, @) {
     $command eq 'unlisted' or $command eq 'donate' or return NEXT;

plugins/users

@@ -1,8 +1,8 @@
 #!perl
 
-HELP "<account>" => "[Pay with your account and] show balance";
-HELP "list" => "List accounts and balances";
-HELP "shame" => "Display Hall of Shame (negative balances)";
+HELP1 "<account>" => "[Pay with your account and] show balance";
+HELP  "list" => "List accounts and balances";
+HELP  "shame" => "Display Hall of Shame (negative balances)";
 
 sub command :Tab(list,ls,shame,USERS) ($self, $cart, $command, @) {
     return $self->list  if $command eq 'list';

plugins/withdraw

@@ -1,6 +1,6 @@
 #!perl
 
-HELP "withdraw <amount>" => "Withdraw from your account";
+HELP1 "withdraw <amount>" => "Withdraw from your account";
 
 sub command :Tab(withdraw) ($self, $cart, $command, @) {
     if (defined parse_amount($command)) {

revbank

@@ -19,7 +19,7 @@ use RevBank::Messages;
 use RevBank::Cart;
 
 our $VERSION = "3.3";
-our %HELP = (
+our %HELP1 = (
     "abort" => "Abort the current transaction",
 );
 

revbank.accounts

@@ -0,0 +1,2 @@
+juerd              +163.48 2022-06-04_02:19:56 +@2021-12-03_18:27:54
+bla                 -36.00 2022-01-19_17:11:25 -@2022-01-19_17:00:43