bitlair/revbank
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove redundant checks

Browse source 
Signatures already do arity-checking.
This commit is contained in:
Juerd Waalboer 2022-10-31 16:37:19 +01:00
parent db73324c4e
commit 44d17e6ae0
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/RevBank/Cart.pm
View file

@ -27,12 +27,13 @@ sub add_entry($self, $entry) {
} }
sub add($self, $amount, $description, $data = {}) { sub add($self, $amount, $description, $data = {}) {
Carp::croak "Unitialized amount; possibly a deprecated call style (\$cart->add(undef, ...))" Carp::croak "Non-hash data argument; possibly a deprecated call style"
if not defined $amount; if not ref $data;
Carp::croak "Non-hash data argument; possibly a deprecated call style (\$cart->add(\$user, ...)"
if @_ == 4 and not ref $data; # Old pre-v3 call styles:
Carp::croak "Missing description; possibly a deprecated call style (\$cart->add(\$entry); use add_entry instead)" # ->add(undef, ...) => just remove the "undef,"
if not defined $description; # ->add($user, ...) => use $cart->add(...)->add_contra($user, ...)
# ->add($entry) => use $cart->add_entry($entry)
return $self->add_entry(RevBank::Cart::Entry->new($amount, $description, $data)); return $self->add_entry(RevBank::Cart::Entry->new($amount, $description, $data));
} }