From 44d17e6ae00b054d620060b4511cb696443be3ac Mon Sep 17 00:00:00 2001
From: Juerd Waalboer <juerd@tnx.nl>
Date: Mon, 31 Oct 2022 16:37:19 +0100
Subject: [PATCH] Remove redundant checks

Signatures already do arity-checking.
---
 lib/RevBank/Cart.pm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/lib/RevBank/Cart.pm b/lib/RevBank/Cart.pm
index d05fe7a..e06ce31 100644
--- a/lib/RevBank/Cart.pm
+++ b/lib/RevBank/Cart.pm
@@ -27,12 +27,13 @@ sub add_entry($self, $entry) {
 }
 
 sub add($self, $amount, $description, $data = {}) {
-    Carp::croak "Unitialized amount; possibly a deprecated call style (\$cart->add(undef, ...))"
-        if not defined $amount;
-    Carp::croak "Non-hash data argument; possibly a deprecated call style (\$cart->add(\$user, ...)"
-        if @_ == 4 and not ref $data;
-    Carp::croak "Missing description; possibly a deprecated call style (\$cart->add(\$entry); use add_entry instead)"
-        if not defined $description;
+    Carp::croak "Non-hash data argument; possibly a deprecated call style"
+        if not ref $data;
+
+    # Old pre-v3 call styles:
+    # ->add(undef, ...)  => just remove the "undef,"
+    # ->add($user, ...)  => use $cart->add(...)->add_contra($user, ...)
+    # ->add($entry)      => use $cart->add_entry($entry)
 
     return $self->add_entry(RevBank::Cart::Entry->new($amount, $description, $data));
 }