fffb2d72e9
(Bumps version to 3.8 because admins should update the plugin list.) Deduplication didn't work on quantified additions, i.e. if you added "20x clubmate" when there was already clubmate in the cart, it would add just ONE item, and have a lingering message that the next thing would be multiplied by 20. This old bug was especially annoying if there is a barcode "20x clubmate" to scan 20 bottles (which is the size of a crate), and this is repeated. The fix also uncovered another bug: newly added entries were selected too early. There are two hooks, hook_add_entry and hook_added_entry, and of course the selection should happen in between, not before the former. No entry in UPGRADING.md, because I think it is extremely unlikely that any plugin author will have used the selection feature yet, which is very new.
31 lines
1.1 KiB
Perl
31 lines
1.1 KiB
Perl
#!perl
|
|
|
|
# Deduplication merges duplicate entries in the cart, e.g.
|
|
# 3x cola + 4x cola = 7x cola.
|
|
#
|
|
# Plugins that support this, set the "deduplicate" attribute to a string key
|
|
# that is used to determine which entries are equal. It is the responsibility
|
|
# of the plugin that sets this, to ensure that the entries are indeed exactly
|
|
# the same, if their deduplicate keys are equal.
|
|
#
|
|
# The recommended value for the deduplicate attribute is join("/", $plugin_id,
|
|
# $unique_id), where $plugin_id can be obtained from $self->id in interactive
|
|
# methods or $class->id in hooks. Including the plugin id avoids deduplicating
|
|
# across plugins, that are probably not aware of eachothers $unique_id's.
|
|
|
|
use List::Util qw(sum any);
|
|
|
|
sub hook_added_entry($class, $cart, $added_entry, @) {
|
|
my $key = $added_entry->attribute('deduplicate') or return;
|
|
|
|
my @dedupe = grep {
|
|
$_->attribute('deduplicate') eq $key
|
|
} $cart->entries('deduplicate');
|
|
|
|
@dedupe >= 2 or return;
|
|
|
|
$dedupe[0]->quantity(sum map { $_->quantity } @dedupe);
|
|
$cart->select($dedupe[0]);
|
|
|
|
$cart->delete($_) for @dedupe[1 .. $#dedupe];
|
|
}
|