Commit graph

16 commits

Author SHA1 Message Date
Juerd Waalboer
7990c43371 given/take: Change verb tense
When the transaction is still pending, the past tense is incorrect.

This is not relevant for the contras, because those descriptions are
only displayed in logs, after the fact.
2024-11-17 01:10:58 +01:00
Juerd Waalboer
09411bb6c0 give: Don't do checkout with description as username
Originally, this command didn't have a description parameter. Foo would
use `give xyzzy 10 foo`. Then, a description parameter was added. For
backwards compatibility, if you would enter a username (like `foo` in
this example) in the place of the description, it would finalize the
transaction using that.

However, as the user base grows, several reasonable descriptions exist as
user account names, and that would finalize the transaction under the
wrong user.

It's time to break backward compatibility. If you don't want to leave a
message (it's still optional), that can be done with `x` (like the
`donate` command), or in advanced mode, with `""`.

Because it's likely that people are still very much used to just leaving
the description out, if you enter something that happens to match an
existing username, the input will be rejected.

The current equivalent command line would be `give xyzzy 10 ""; foo` or
`give xyzzy 10 x; foo`. If the `;` (new since v5.0.0) is left out, the
trailing `foo` has to be confirmed with a second press of the enter key.
2023-12-26 05:47:29 +01:00
Juerd Waalboer
eed0db7897 Cleanup: use subroutine signatures, remove deprecated methods.
The signatures feature has been "experimental" since Perl 5.20 (May 2014), but
expected to stay. After 8 years I'm ready to take the risk :)

Have added Perl v5.28 (June 2018) as the minimum requirement, even though the
current revbank should work with 5.20, to see if this bothers any users. Perl
v5.28 is in Debian "buster", which is now oldstable.
2021-12-03 18:00:34 +01:00
Juerd Waalboer
38a0229899 Ditch floating point numbers, use cents instead; bump version to 3.2 2021-12-02 22:18:06 +01:00
Juerd Waalboer
31a1aa5c45 Fix spelling
Reported by Noor
2020-02-07 01:36:52 +01:00
Juerd Waalboer
1cbc906f1e Further update to new ledger-like internals 2019-11-05 00:57:39 +01:00
Juerd Waalboer
fa60e1081a chmod 644 plugins/*
Undoes 714b337 because github seems to no longer require chmod +x
for syntax highlighting extensionless files.
2019-08-07 15:42:16 +02:00
Juerd Waalboer
ab724a03f9 Bug fix: passing unchecked user input led to persistent case change 2019-05-27 22:42:48 +02:00
Juerd Waalboer
af4d05c4da Round amounts in prompt for give/take reason 2017-04-24 21:49:20 +02:00
Juerd Waalboer
e27106e5b5 Refactor "give", happens to fix bug :-) 2013-02-28 16:50:08 +01:00
Juerd Waalboer
6a614830a6 Wrong variable... 2013-02-28 16:36:48 +01:00
Juerd Waalboer
6372e30cac "give" now takes a reason like "take", only optional args between [] in help.
Contributed by BugBlue
2013-02-28 16:31:05 +01:00
Juerd Waalboer
2020bfea20 Use canonical username, not the raw user input. 2013-02-26 13:02:22 +01:00
Juerd Waalboer
4995e84b83 Git highlight alleen met +x? Okay, dan doen we +x :-) 2013-02-26 04:44:29 +01:00
Juerd Waalboer
18d1a552fb Shebangs voor syntax highlighting 2013-02-26 04:42:45 +01:00
Juerd Waalboer
c157ea0214 RevBank 2.0, a rewrite. It's plugin based now. 2013-02-26 04:11:13 +01:00