bitlair/revbank
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cleanup: use subroutine signatures, remove deprecated methods.

Browse source 
The signatures feature has been "experimental" since Perl 5.20 (May 2014), but
expected to stay. After 8 years I'm ready to take the risk :)

Have added Perl v5.28 (June 2018) as the minimum requirement, even though the
current revbank should work with 5.20, to see if this bothers any users. Perl
v5.28 is in Debian "buster", which is now oldstable.
This commit is contained in:
Juerd Waalboer 2021-12-03 18:00:34 +01:00
parent 1661661ffd
commit eed0db7897
45 changed files with 233 additions and 444 deletions
Download patch file Download diff file Expand all files Collapse all files

30
lib/RevBank/Users.pm
View file

@ -1,11 +1,16 @@
package RevBank::Users;
use strict;
use v5.28;
use warnings;
use feature qw(signatures);
no warnings qw(experimental::signatures);
use RevBank::Global;
use RevBank::Plugins;
my $filename = "revbank.accounts";
sub _read {
sub _read() {
my @users;
open my $fh, $filename or die $!;
/\S/ and push @users, [split " "] while readline $fh;
@ -13,22 +18,19 @@ sub _read {
return { map { lc($_->[0]) => $_ } @users };
}
sub names {
sub names() {
return map $_->[0], values %{ _read() };
}
sub balance {
my ($name) = @_;
return _read()->{ lc $name }->[1];
sub balance($username) {
return _read()->{ lc $username }->[1];
}
sub since {
my ($name) = @_;
return _read()->{ lc $name }->[3];
sub since($username) {
return _read()->{ lc $username }->[3];
}
sub create {
my ($username) = @_;
sub create($username) {
open my $fh, '>>', $filename or die $!;
my $now = now();
print {$fh} "$username 0.00 $now\n" or die $!;
@ -36,8 +38,7 @@ sub create {
RevBank::Plugins::call_hooks("user_created", $username);
}
sub update {
my ($username, $delta, $transaction_id) = @_;
sub update($username, $delta, $transaction_id) {
open my $in, 'revbank.accounts' or die $!;
open my $out, ">.revbank.$$" or die $!;
my $old;
@ -75,8 +76,7 @@ sub update {
);
}
sub parse_user {
my ($username) = @_;
sub parse_user($username) {
my $users = _read();
return undef if not exists $users->{ lc $username };
return $users->{ lc $username }->[0];