bitlair/revbank
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Deprecate nyan, game, and creating users via deposit.

Browse source
This commit is contained in:
Juerd Waalboer 2019-05-15 01:24:20 +02:00
parent 07acf7f76e
commit da11114b8f
6 changed files with 48 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
README.md
View file

@ -2,6 +2,25 @@
revbank - Banking for hackerspace visitors revbank - Banking for hackerspace visitors
# ANNOUNCEMENTS
The following will disappear in a future version:
## Deprecated: `nyan`, `game`
These non-serious, non-banking plugins will be removed. Please remove them
from `revbank.plugins`.
## Deprecated: creating new accounts with `deposit`
For a while now, there has been a dedicated plugin, `adduser` to create new
accounts. The old way of creating new accounts (unknown input after a
`deposit` command was assumed to be the name of the a account) did not allow
for any input validation and would cause trouble if a user name already
existed.
Please add `adduser` to `revbank.plugins`.
# DESCRIPTION # DESCRIPTION
Maybe I'll write some documentation, but not now. Maybe I'll write some documentation, but not now.

6
plugins/deposit
View file

@ -14,6 +14,12 @@ sub command :Tab(deposit) {
if ($cart->select_items('is_deposit')) { if ($cart->select_items('is_deposit')) {
# No other plugin recognised the input, so it must be a new user. # No other plugin recognised the input, so it must be a new user.
$self->{new_user} = $command; $self->{new_user} = $command;
my $x = RevBank::Plugin::adduser->can("command")
? "Please use \e[4madduser\e[0m instead."
: "Please enable the \e[4madduser\e[0m plugin.";
warn "Creating accounts with \e[4mdeposit\e[m is deprecated. $x\n";
return "Add new account for user '$command'?", \&create; return "Add new account for user '$command'?", \&create;
} }

2
plugins/game
View file

@ -1,5 +1,7 @@
#!perl #!perl
warn "The game plugin is deprecated and will be removed from a future revbank";
#Scan-foo-game for Revbank - (C)Edwin Eefting (psy0rz) #Scan-foo-game for Revbank - (C)Edwin Eefting (psy0rz)
#Released under GPL or whatever revbank uses as license :) #Released under GPL or whatever revbank uses as license :)

2
plugins/nyan
View file

@ -1,5 +1,7 @@
#!perl #!perl
warn "The nyan plugin is deprecated and will be removed from a future revbank";
HELP "nyan" => "Nyan!"; HELP "nyan" => "Nyan!";
sub command :Tab(nyan,nyanutf8) { sub command :Tab(nyan,nyanutf8) {

19
revbank
View file

@ -218,6 +218,25 @@ OUTER: for (;;) {
revbank - Banking for hackerspace visitors revbank - Banking for hackerspace visitors
=head1 ANNOUNCEMENTS
The following will disappear in a future version:
=head2 Deprecated: C<nyan>, C<game>
These non-serious, non-banking plugins will be removed. Please remove them
from C<revbank.plugins>.
=head2 Deprecated: creating new accounts with C<deposit>
For a while now, there has been a dedicated plugin, C<adduser> to create new
accounts. The old way of creating new accounts (unknown input after a
C<deposit> command was assumed to be the name of the a account) did not allow
for any input validation and would cause trouble if a user name already
existed.
Please add C<adduser> to C<revbank.plugins>.
=head1 DESCRIPTION =head1 DESCRIPTION
Maybe I'll write some documentation, but not now. Maybe I'll write some documentation, but not now.

3
revbank.plugins
View file

@ -20,9 +20,6 @@ adduser
beep_terminal beep_terminal
#nyan # fun, but not compatible with dumb terminals
#game # Scan-foo game
# Then, plugins that apply heuristics # Then, plugins that apply heuristics
products # matches product IDs (barcodes) products # matches product IDs (barcodes)