From 6b2d8fdee3addec16d505d39fe23a024cf39a0b0 Mon Sep 17 00:00:00 2001
From: Juerd Waalboer <juerd@tnx.nl>
Date: Sun, 12 Feb 2023 22:01:31 +0100
Subject: [PATCH] Move deprecation warning to separate plugin

---
 UPGRADING.md           |  7 +++++++
 plugins/deprecated_raw | 10 ++++++++++
 plugins/withdraw       |  6 ------
 3 files changed, 17 insertions(+), 6 deletions(-)
 create mode 100644 plugins/deprecated_raw

diff --git a/UPGRADING.md b/UPGRADING.md
index 106fe37..a682da0 100644
--- a/UPGRADING.md
+++ b/UPGRADING.md
@@ -6,6 +6,13 @@ Deduplication is moved from individual plugins to a plugin that does that. If
 you want to keep deduplication of cart items, and you probably do want that,
 add `deduplicate` to `revbank.plugins` just below `repeat`.
 
+The deprecation warning was moved from the `withdraw` plugin to a new plugin
+called `deprecated_raw`. If you're upgrading from an older versions and some of
+your users have been around since before the withdraw/unlisted split, you may
+want to keep the deprecation warning. But for new RevBank installations it does
+not make sense. To keep providing these warnings to users that enter raw
+amounts, add `deprecated_raw` to the very end of `revbank.plugins`.
+
 # (2022-12-25) RevBank 3.6
 
 ## Update your `revbank.plugins`
diff --git a/plugins/deprecated_raw b/plugins/deprecated_raw
new file mode 100644
index 0000000..de96d39
--- /dev/null
+++ b/plugins/deprecated_raw
@@ -0,0 +1,10 @@
+#!perl
+
+sub command :Tab(withdraw) ($self, $cart, $command, @) {
+    if (defined eval { parse_amount($command) }) {
+        warn "Note: raw amounts for withdrawal or unlisted products are no longer supported.\n\n";
+        warn "Please use the 'withdraw' command to take money out of your revbank account, or\n";
+        warn "the 'unlisted' command to pay for an unlisted product.\n\n";
+    }
+    return NEXT;
+}
diff --git a/plugins/withdraw b/plugins/withdraw
index a1aa403..16437ae 100644
--- a/plugins/withdraw
+++ b/plugins/withdraw
@@ -3,12 +3,6 @@
 HELP1 "withdraw <amount>" => "Withdraw from your account";
 
 sub command :Tab(withdraw) ($self, $cart, $command, @) {
-    if (defined eval { parse_amount($command) }) {
-        warn "Note: raw amounts for withdrawal or unlisted products are no longer supported.\n\n";
-        warn "Please use the 'withdraw' command to take money out of your revbank account, or\n";
-        warn "the 'unlisted' command to pay for an unlisted product.\n\n";
-    }
-
     $command eq 'withdraw' or return NEXT;
 
     return "Amount to withdraw from your account", \&amount;