From 599bf1bc98d7f4c78fa7e8801cce60c6833576b1 Mon Sep 17 00:00:00 2001
From: Juerd Waalboer <juerd@tnx.nl>
Date: Wed, 28 Aug 2024 05:28:08 +0200
Subject: [PATCH] Fix unit tests for fileio: create tempfiles in cwd

RevBank uses atomic file replacement by creating a new file and renaming
it over the old one. The newly created file is always in cwd, and
for the atomic rename() to work it must reside on the same filesystem as
the file it's replacing. Since File::Temp does the right thing and
creates files in /tmp by default, and /tmp is usually on a different
filesystem, these unit tests didn't actually work.

I don't know why they did work in the past. There doesn't seem to have
been any relevant change (or any at all, for that matter) to File::Temp,
which has had this behavior for ages. But I can't imagine that my /tmp
has only recently become a tmpfs mount either.

In any case, the issue is fixed by making File::Temp do the wrong thing,
which is to create its files in the cwd.
---
 revbank    |  2 +-
 t/fileio.t | 12 ++++++++----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/revbank b/revbank
index d5ae6f7..af9fa7f 100755
--- a/revbank
+++ b/revbank
@@ -17,7 +17,7 @@ use RevBank::Messages;
 use RevBank::Cart;
 use RevBank::Prompt;
 
-our $VERSION = "6.2.2";
+our $VERSION = "6.2.3";
 our %HELP1 = (
     "abort" => "Abort the current transaction",
 );
diff --git a/t/fileio.t b/t/fileio.t
index a227038..c7b4a7e 100644
--- a/t/fileio.t
+++ b/t/fileio.t
@@ -9,8 +9,12 @@ use RevBank::FileIO;
 # ChatGPT didn't realise that ::FileIO doesn't export its functions
 use RevBank::Global;
 
+sub _newtmp {
+    File::Temp->new(DIR => ".");  # Not /tmp because RevBank::FileIO only does cwd
+}
+
 subtest "slurp" => sub {
-    my $tmp = File::Temp->new();
+    my $tmp = _newtmp;
     my $data = "foo\nbar\nbaz\n";
     print $tmp $data;
     close $tmp;
@@ -19,7 +23,7 @@ subtest "slurp" => sub {
 };
 
 subtest "spurt" => sub {
-    my $tmp = File::Temp->new();
+    my $tmp = _newtmp;
     spurt($tmp->filename, "foo\nbar\nbaz\n");
     open my $fh, "<", $tmp->filename;
     local $/;
@@ -29,7 +33,7 @@ subtest "spurt" => sub {
 };
 
 subtest "append" => sub {
-    my $tmp = File::Temp->new();
+    my $tmp = _newtmp;
     spurt($tmp->filename, "foo\n");
     append($tmp->filename, "bar\n", "baz\n");
     open my $fh, "<", $tmp->filename;
@@ -40,7 +44,7 @@ subtest "append" => sub {
 };
 
 subtest "rewrite" => sub {
-    my $tmp = File::Temp->new();
+    my $tmp = _newtmp;
     spurt($tmp->filename, "foo\nbar\nbaz\n");
     rewrite($tmp->filename, sub {
         my ($line) = @_;