bitlair/revbank
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better check for lost controlling terminal

Browse source 
The eof check has to read a character. It happened to work, but it
was not the right way to check this.

Also added a warning for when someone does "ssh $host revbank" instead
of "ssh -t $host revbank".
This commit is contained in:
Juerd Waalboer 2024-02-01 00:03:26 +01:00
parent ce93ea86fa
commit 4b6fa729ff
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
revbank
View file

@ -6,6 +6,7 @@ use feature qw(signatures isa);
no warnings "experimental::signatures";
use List::Util qw(uniq);
use POSIX qw(ttyname);
use FindBin qw($RealBin);
use lib "$RealBin/lib";
@ -15,7 +16,7 @@ use RevBank::Messages;
use RevBank::Cart;
use RevBank::Prompt;
our $VERSION = "6.0.1";
our $VERSION = "6.0.2";
our %HELP1 = (
"abort" => "Abort the current transaction",
);
@ -34,8 +35,12 @@ if (@ARGV) {
@words and not ref $words[0] or die "Syntax error.\n";
push @words, @ARGV[3 .. $#ARGV] if @ARGV > 3;
push @words, "help" if not @words;
} elsif (not ttyname fileno STDIN) {
warn "\e[31;1mNo controlling terminal, things will be borken!\n";
warn "Use ssh -t (or RequestTTY in .ssh/config) for interactive sessions.\e[m\n";
}
$| = 1;
my $cart = RevBank::Cart->new;
@ -110,8 +115,7 @@ OUTER: for (;;) {
$prompt, \@completions, $default, $pos, $cart, \@plugins
);
if (not defined $input) {
# Controlling terminal gone
exit if eof STDIN;
exit if not ttyname fileno STDIN; # Controlling terminal gone
}
call_hooks "input", $cart, $input, $split_input;