Linter + Dashboard fixes

roles/services/tasks/discord_bot.yaml

@@ -1,4 +1,5 @@
 ---
+
 - name: Install dependencies
   ansible.builtin.apt:
     name:
@@ -32,12 +33,12 @@
     dest: /etc/systemd/system/discord-bot.service
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   notify: restart discord-bot
 
 - name: Start discord-bot
   ansible.builtin.systemd:
     name: discord-bot
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true

roles/services/tasks/ircbot.yaml

@@ -29,7 +29,7 @@
   ansible.builtin.systemd:
     name: irc-bot
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true
 
 - name: Create helpers dir
@@ -63,7 +63,7 @@
   ansible.builtin.systemd:
     name: irc-photos
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true
 
 - name: Install doorduino notification
@@ -92,5 +92,5 @@
   ansible.builtin.systemd:
     name: irc-doorduino
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true

roles/services/tasks/main.yaml

@@ -1,22 +1,43 @@
 ---
-- tags: services_ircbot
+
+- name: Import ircbot
   ansible.builtin.import_tasks:
     file: ircbot.yaml
+  tags:
+    - services_ircbot
 
-- tags: services_discord_bot
-  ansible.builtin.import_tasks: discord_bot.yaml
+- name: Import services_discord_bot
+  ansible.builtin.import_tasks:
+    file: discord_bot.yaml
+  tags:
+    - services_discord_bot
 
-- tags: services_siahsd
-  import_tasks: siahsd.yaml
+- name: Import siahsd
+  ansible.builtin.import_tasks:
+    file: siahsd.yaml
+  tags:
+    - services_siahsd
 
-- tags: services_spacestated
-  import_tasks: spacestated.yaml
+- name: Import spacestated
+  ansible.builtin.import_tasks:
+    file: spacestated.yaml
+  tags:
+    - services_spacestated
 
-- tags: services_mastodon_spacestate
-  import_tasks: mastodon_spacestate.yaml
+- name: Import mastodon_spacestate.yaml
+  ansible.builtin.import_tasks:
+    file: mastodon_spacestate.yaml
+  tags:
+    - services_mastodon_spacestate
 
-- tags: services_wifi_mqtt
-  import_tasks: wifi_mqtt.yaml
+- name: import wifi_mqtt
+  ansible.builtin.import_tasks:
+    file: wifi_mqtt.yaml
+  tags:
+    - services_wifi_mqtt
 
-- tags: services_power_mqtt
-  import_tasks: power_mqtt.yaml
+- name: Import power_mqt
+  ansible.builtin.import_tasks:
+    file: power_mqtt.yaml
+  tags:
+    - services_power_mqtt

roles/services/tasks/mastodon_spacestate.yaml

@@ -11,7 +11,7 @@
     version: main
     dest: /var/lib/mastodon-spacestate
     accept_hostkey: yes
-  notify: restart mastodon-spacestate
+  notify: Restart mastodon-spacestate
 
 - name: Install config
   ansible.builtin.template:
@@ -20,7 +20,7 @@
     owner: root
     group: root
     mode: 0655
-  notify: restart mastodon-spacestate
+  notify: Restart mastodon-spacestate
 
 - name: Install service file
   ansible.builtin.template:
@@ -29,11 +29,11 @@
     owner: root
     group: root
     mode: 0644
-  notify: restart mastodon-spacestate
+  notify: Restart mastodon-spacestate
 
 - name: Start mastodon-spacestate
   ansible.builtin.systemd:
     name: mastodon-spacestate
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true

roles/services/tasks/power_mqtt.yaml

@@ -10,7 +10,7 @@
     owner: root
     group: root
     mode: 0755
-  notify: restart power-mqtt
+  notify: Restart power-mqtt
 
 - name: Remove old service
   ansible.builtin.file:
@@ -27,13 +27,13 @@
   vars:
     description: "SMD630 to MQTT Probe"
     exec: "/var/lib/power-mqtt.py %i"
-  notify: restart power-mqtt@
+  notify: Restart power-mqtt@
 
 - name: Enable power-mqtt
   ansible.builtin.systemd:
     name: "power-mqtt@{{ item.net }}/{{ item.ip }}"
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true
   with_items:
     - net: space

roles/services/tasks/siahsd.yaml

@@ -7,6 +7,7 @@
     state: directory
     owner: siahsd
     group: nogroup
+    mode: "0750"
   with_items:
     - /var/log/siahsd
     - /var/lib/siahsd
@@ -17,8 +18,8 @@
     dest: /etc/siahsd.conf
     owner: root
     group: root
-    mode: 0644
-  notify: restart siahsd
+    mode: "0644"
+  notify: Restart siahsd
 
 - name: Install service file
   ansible.builtin.template:
@@ -26,24 +27,13 @@
     dest: /etc/systemd/system/siahsd.service
     owner: root
     group: root
-    mode: 0644
-  notify: restart siahsd
+    mode: "0644"
+  notify: Restart siahsd
 
 - name: Start siahsd
   ansible.builtin.systemd:
     name: siahsd
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true
 
-- name: Allow siahsd traffic
-  ansible.builtin.iptables:
-    chain: INPUT
-    protocol: udp
-    destination_port: "4000"
-    jump: ACCEPT
-    ip_version: "{{ item }}"
-    action: insert
-  with_items: [ ipv4, ipv6 ]
-  notify: persist iptables
-  when: not nft | bool

roles/services/tasks/spacestated.yaml

@@ -24,7 +24,7 @@
     version: main
     dest: /var/lib/spacestated/spacestated
     accept_hostkey: yes
-  notify: restart spacestated
+  notify: Restart spacestated
 
 - name: Install service file
   ansible.builtin.template:
@@ -33,11 +33,11 @@
     owner: root
     group: root
     mode: 0644
-  notify: restart spacestated
+  notify: Restart spacestated
 
 - name: Start spacestated
   ansible.builtin.systemd:
     name: spacestated
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true

roles/services/tasks/wifi_mqtt.yaml

@@ -7,25 +7,25 @@
       - make
 
 - name: Clone source
-  git:
+  ansible.builtin.git:
     repo: https://github.com/bitlair/wifi-mqtt.git
     version: main
     dest: /var/lib/wifi-mqtt
     accept_hostkey: yes
-  notify: restart wifi-mqtt
+  notify: Restart wifi-mqtt
 
 - name: Install service file
-  template:
+  ansible.builtin.template:
     src: wifi-mqtt.service
     dest: /etc/systemd/system/wifi-mqtt.service
     owner: root
     group: root
-    mode: 0644
-  notify: restart wifi-mqtt
+    mode: "0644"
+  notify: Restart wifi-mqtt
 
 - name: Start wifi-mqtt
-  systemd:
+  ansible.builtin.systemd:
     name: wifi-mqtt
     state: started
-    enabled: yes
+    enabled: true
     daemon_reload: true