Automated changes from linter ;P

roles/services/handlers/main.yaml

@@ -1,56 +1,57 @@
 ---
-- import_tasks: ../../common/handlers/main.yaml
+- ansible.builtin.import_tasks:
+    file: ../../common/handlers/main.yaml
 
 - name: restart irc-bot
-  systemd:
+  ansible.builtin.systemd:
     name: irc-bot
     state: restarted
     daemon_reload: true
 
 - name: restart irc-photos
-  systemd:
+  ansible.builtin.systemd:
     name: irc-photos
     state: restarted
     daemon_reload: true
 
 - name: restart irc-doorduino
-  systemd:
+  ansible.builtin.systemd:
     name: irc-doorduino
     state: restarted
     daemon_reload: true
 
 - name: restart discord-bot
-  systemd:
+  ansible.builtin.systemd:
     name: discord-bot
     state: restarted
     daemon_reload: true
 
 - name: restart siahsd
-  systemd:
+  ansible.builtin.systemd:
     name: siahsd
     state: restarted
     daemon_reload: true
 
 - name: restart spacestated
-  systemd:
+  ansible.builtin.systemd:
     name: spacestated
     state: restarted
     daemon_reload: true
 
 - name: restart mastodon-spacestate
-  systemd:
+  ansible.builtin.systemd:
     name: mastodon-spacestate
     state: restarted
     daemon_reload: true
 
 - name: restart wifi-mqtt
-  systemd:
+  ansible.builtin.systemd:
     name: wifi-mqtt
     state: restarted
     daemon_reload: true
 
 - name: restart power-mqtt
-  systemd:
+  ansible.builtin.systemd:
     name: power-mqtt
     state: restarted
     daemon_reload: true

roles/services/tasks/discord_bot.yaml

@@ -1,23 +1,25 @@
 ---
 - name: Install dependencies
-  apt:
+  ansible.builtin.apt:
     name:
       - python3-paho-mqtt
       - python3-tz
       - virtualenv
 
 - name: Create virtualenv
-  command: virtualenv /opt/miflora_exporter/.venv
+  ansible.builtin.command:
+    cmd: virtualenv /opt/miflora_exporter/.venv
   args:
     creates: /var/lib/discord-bot/.venv
 
 - name: Install Python dependencies
-  shell: . .venv/bin/activate && pip install -r requirements.txt
+  ansible.builtin.shell:
+    cmd: . .venv/bin/activate && pip install -r requirements.txt
   args:
     chdir: /var/lib/discord-bot
 
 - name: Clone source
-  git:
+  ansible.builtin.git:
     repo: https://github.com/bitlair/discord-bot.git
     version: main
     dest: /var/lib/discord-bot
@@ -25,7 +27,7 @@
   notify: restart discord-bot
 
 - name: Install service file
-  template:
+  ansible.builtin.template:
     src: discord-bot.service
     dest: /etc/systemd/system/discord-bot.service
     owner: root
@@ -34,7 +36,7 @@
   notify: restart discord-bot
 
 - name: Start discord-bot
-  systemd:
+  ansible.builtin.systemd:
     name: discord-bot
     state: started
     enabled: yes

roles/services/tasks/ircbot.yaml

@@ -1,6 +1,6 @@
 ---
 - name: Clone source
-  git:
+  ansible.builtin.git:
     repo: https://github.com/bitlair/irc-bot.git
     version: master
     dest: /var/lib/irc-bot
@@ -8,13 +8,13 @@
   notify: restart irc-bot
 
 - name: Link irc-say
-  file:
+  ansible.builtin.file:
     state: link
     src: /var/lib/irc-bot/irc-say
     dest: /usr/local/bin/irc-say
 
 - name: Install service file
-  template:
+  ansible.builtin.template:
     src: generic.service
     dest: /etc/systemd/system/irc-bot.service
     owner: root
@@ -26,19 +26,19 @@
   notify: restart irc-bot
 
 - name: Start irc-bot
-  systemd:
+  ansible.builtin.systemd:
     name: irc-bot
     state: started
     enabled: yes
     daemon_reload: true
 
 - name: Create helpers dir
-  file:
+  ansible.builtin.file:
     path: /var/lib/irc-helpers
     state: directory
 
 - name: Install photos notification
-  template:
+  ansible.builtin.template:
     src: irc-photos.sh
     dest: /var/lib/irc-helpers/photos.sh
     owner: root
@@ -47,7 +47,7 @@
   notify: restart irc-photos
 
 - name: Install photos notification service
-  template:
+  ansible.builtin.template:
     src: generic.service
     dest: /etc/systemd/system/irc-photos.service
     owner: root
@@ -60,14 +60,14 @@
   notify: restart irc-photos
 
 - name: Start irc-photos
-  systemd:
+  ansible.builtin.systemd:
     name: irc-photos
     state: started
     enabled: yes
     daemon_reload: true
 
 - name: Install doorduino notification
-  template:
+  ansible.builtin.template:
     src: irc-doorduino.sh
     dest: /var/lib/irc-helpers/doorduino.sh
     owner: root
@@ -76,7 +76,7 @@
   notify: restart irc-doorduino
 
 - name: Install doorduino notification service
-  template:
+  ansible.builtin.template:
     src: generic.service
     dest: /etc/systemd/system/irc-doorduino.service
     owner: root
@@ -89,7 +89,7 @@
   notify: restart irc-doorduino
 
 - name: Start irc-doorduino
-  systemd:
+  ansible.builtin.systemd:
     name: irc-doorduino
     state: started
     enabled: yes

roles/services/tasks/main.yaml

@@ -1,9 +1,10 @@
 ---
 - tags: services_ircbot
-  import_tasks: ircbot.yaml
+  ansible.builtin.import_tasks:
+    file: ircbot.yaml
 
 - tags: services_discord_bot
-  import_tasks: discord_bot.yaml
+  ansible.builtin.import_tasks: discord_bot.yaml
 
 - tags: services_siahsd
   import_tasks: siahsd.yaml

roles/services/tasks/mastodon_spacestate.yaml

@@ -1,12 +1,12 @@
 ---
 - name: Install dependencies
-  apt:
+  ansible.builtin.apt:
     name:
       - python3-mastodon
       - python3-paho-mqtt
 
 - name: Clone source
-  git:
+  ansible.builtin.git:
     repo: https://github.com/bitlair/mastodon-spacestate.git
     version: main
     dest: /var/lib/mastodon-spacestate
@@ -14,7 +14,7 @@
   notify: restart mastodon-spacestate
 
 - name: Install config
-  template:
+  ansible.builtin.template:
     src: mastodon-spacestate-config.py
     dest: /var/lib/mastodon-spacestate/config.py
     owner: root
@@ -23,7 +23,7 @@
   notify: restart mastodon-spacestate
 
 - name: Install service file
-  template:
+  ansible.builtin.template:
     src: mastodon-spacestate.service
     dest: /etc/systemd/system/mastodon-spacestate.service
     owner: root
@@ -32,7 +32,7 @@
   notify: restart mastodon-spacestate
 
 - name: Start mastodon-spacestate
-  systemd:
+  ansible.builtin.systemd:
     name: mastodon-spacestate
     state: started
     enabled: yes

roles/services/tasks/power_mqtt.yaml

@@ -1,10 +1,10 @@
 ---
 - name: Install dependencies
-  apt:
+  ansible.builtin.apt:
     name: [python3-paho-mqtt, python3-requests]
 
 - name: Install power-mqtt
-  template:
+  ansible.builtin.template:
     src: power-mqtt.py
     dest: /var/lib/power-mqtt.py
     owner: root
@@ -13,12 +13,12 @@
   notify: restart power-mqtt
 
 - name: Remove old service
-  file:
+  ansible.builtin.file:
     path: /etc/systemd/system/power-mqtt.service
     state: absent
 
 - name: Install power-mqtt service
-  template:
+  ansible.builtin.template:
     src: generic.service
     dest: /etc/systemd/system/power-mqtt@.service
     owner: root
@@ -30,7 +30,7 @@
   notify: restart power-mqtt@
 
 - name: Enable power-mqtt
-  systemd:
+  ansible.builtin.systemd:
     name: "power-mqtt@{{ item.net }}/{{ item.ip }}"
     state: started
     enabled: yes

roles/services/tasks/siahsd.yaml

@@ -2,7 +2,7 @@
 # TODO: Install and build
 
 - name: Create directories
-  file:
+  ansible.builtin.file:
     path: "{{ item }}"
     state: directory
     owner: siahsd
@@ -12,7 +12,7 @@
     - /var/lib/siahsd
 
 - name: Install config file
-  template:
+  ansible.builtin.template:
     src: siahsd.conf
     dest: /etc/siahsd.conf
     owner: root
@@ -21,7 +21,7 @@
   notify: restart siahsd
 
 - name: Install service file
-  template:
+  ansible.builtin.template:
     src: siahsd.service
     dest: /etc/systemd/system/siahsd.service
     owner: root
@@ -30,14 +30,14 @@
   notify: restart siahsd
 
 - name: Start siahsd
-  systemd:
+  ansible.builtin.systemd:
     name: siahsd
     state: started
     enabled: yes
     daemon_reload: true
 
 - name: Allow siahsd traffic
-  iptables:
+  ansible.builtin.iptables:
     chain: INPUT
     protocol: udp
     destination_port: "4000"

roles/services/tasks/spacestated.yaml

@@ -1,24 +1,25 @@
 ---
 
 - name: Install dependencies
-  apt:
+  ansible.builtin.apt:
     name:
       - php-cli
       - php-snmp
       - make
 
 - name: Install mqtt-simple
-  command: cpan Net::MQTT::Simple
+  ansible.builtin.command:
+    cmd: cpan Net::MQTT::Simple
 
 - name: Add user
-  user:
+  ansible.builtin.user:
     name: spacestated
     home: /var/lib/spacestated
     generate_ssh_key: yes
     ssh_key_type: ed25519
 
 - name: Clone source
-  git:
+  ansible.builtin.git:
     repo: https://github.com/bitlair/spacestated.git
     version: main
     dest: /var/lib/spacestated/spacestated
@@ -26,7 +27,7 @@
   notify: restart spacestated
 
 - name: Install service file
-  template:
+  ansible.builtin.template:
     src: spacestated.service
     dest: /etc/systemd/system/spacestated.service
     owner: root
@@ -35,7 +36,7 @@
   notify: restart spacestated
 
 - name: Start spacestated
-  systemd:
+  ansible.builtin.systemd:
     name: spacestated
     state: started
     enabled: yes

roles/services/tasks/wifi_mqtt.yaml

@@ -1,6 +1,6 @@
 ---
 - name: Install dependencies
-  apt:
+  ansible.builtin.apt:
     name:
       - php-cli
       - php-snmp